Fix deprecated pd.read_json string usage in metrics_engine #16
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compute_metrics called pd.read_json() directly on a JSON string (raw_data["financials"] / raw_data["balance_sheet"]), which already triggered a FutureWarning on every test run: pandas will eventually remove support for passing a literal string this way (it ends up guessing whether the string is content or a file path), turning this into a hard crash rather than just a warning. Wrap both strings in io.StringIO before passing them to pd.read_json, which is the way pandas wants this going forward. Verified with `pytest -W error::FutureWarning`: no FutureWarning is raised anymore. Full suite: 40 passed, 92% coverage on src/. Closes #10
bendikto
added
Src
bendikto
deleted the
10-Fix-deprecated-pd.read_json-string-usage-in-metrics_engine
branch
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compute_metrics called pd.read_json() directly on a JSON string (raw_data["financials"] / raw_data["balance_sheet"]), which already triggered a FutureWarning on every test run: pandas will eventually remove support for passing a literal string this way (it ends up guessing whether the string is content or a file path), turning this into a hard crash rather than just a warning.
Wrap both strings in io.StringIO before passing them to pd.read_json, which is the way pandas wants this going forward.
Verified with
pytest -W error::FutureWarning: no FutureWarning israised anymore. Full suite: 40 passed, 92% coverage on src/.
Closes #10